Pass header flag to Renderer.tablerow method #818
Conversation
When styling tables out of a custom renderer subclass, it's useful to know if the tablerow is in the header or body. Tablecells already get a header flag that is set if the tablecell is in the header. This change adds the flag to tablerows.
|
Closing due to missing tests - going to flag with #981 for future reference as we focus on correcting known issues. |
|
This specific pr is not about parsing, so there's nothing to test here. Also, this is about (gfm) tables, not headings. |
|
Is this a GFM table extension - think all the table stuff in GFM is an extension; so, definitely not an immediate need. |
|
Tables are supported in gfm mode only, and yes, the whole gfm is an extension to markdown, but not github-specific. gfm is on by default. Must remember to adjust the Now that I think about it, this should come in helpful when extending marked, so maybe 0.5.0 would be better? |
|
It's possible. I think what I meant when asking if it was an extension is the GFM spec has certain concepts that are explicitly labeled as extensions - not part of their base specification, which is an extension of the original Markdown.py: https://github.github.com/gfm/ Task lists, tables, and autolinks, for example, are explicitly called out as extensions. Think the focus for us right now is on the base specs for CommonMark and GFM - not extensions - at least according to #956. Think you're probably right about the possibility of helping to inform the 0.5.0 work. Changing. |
joshbruce
modified the milestones:
0.6.0 - Improve developer experience,
0.5.0 - Architecture and extensibility
I'm using it in my fork to put a thicker border under the
I suppose I could hack it by setting that border on the |
|
@joshbruce there is no "gfm markdown", gfm is commonmark + gfm extensions (i.e. tables, task lists, autolinks, etc.) |
|
@Feder1co5oave: Interesting. Did not realize. Thought they were two separate specs - makes life easier then. :) @ksheedlo: Seems odd to ask Marked to do that - tightly couples markup and style, if I'm understanding the resulting markup properly. Can you post the markup that gives you that result? |
|
@Feder1co5oave: #746 - As we consider architecture and extensibility we should start considering what we want Marked to take on beyond the specs a bit more. If we physically separate the parser and whatnot as desicribed by @Nalinc it might become more obvious on how to override/extned; thereby, opening the door to folks to do things like what's in #1030 or here instead of asking Marked to do it - and for us to maintain it. Really don't want to end up in the same situation again where none of us really have time to maintain Marked because it is taking on too much, you know? Tagging in @UziTech and @KostyaTretyak |
When styling tables out of a custom renderer subclass, it's useful to
know if the tablerow is in the header or body. Tablecells already get a
header flag that is set if the tablecell is in the header. This change
adds the flag to tablerows.